-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump storage rules emulator version #5342
Conversation
Codecov ReportBase: 56.43% // Head: 56.43% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5342 +/- ##
=======================================
Coverage 56.43% 56.43%
=======================================
Files 315 315
Lines 21137 21137
Branches 4290 4290
=======================================
Hits 11928 11928
Misses 8184 8184
Partials 1025 1025
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a changelog entry for this.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you need to rerun the linter, but LGTM otherwise.
Also update null_value evaluation accordingly.
Fixes #5251